-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
BUG: Fix concat DataFrame and Series with ignore_index=True #60983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Matthew Roeschke <[email protected]>
|
Hi @rhshadrach Requesting a review as no reviewer is assigned to the PR Thanks |
rhshadrach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Can you add tests where the Series name is None and for axis=1.
|
Hi @rhshadrach I have done the requested changes from the review |
rhshadrach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Thanks @Anurag-Varma |
ignore_index = Truedrops the series name #60723pd.concaton axis "index" has unexpected result concatenating Series and DataFrame with same (column) name #56257doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.